fix bundling of eddsa #935
Conversation
the plugin would have previously just blown up at runtime if a new p4 plugin was used as the APIs called did not exist. The plugin may still blow up at runtime, however there is at least more possibility that it will indeed not blow up
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
| <jenkins.version>2.263.1</jenkins.version> | ||
| <java.level>8</java.level> | ||
| <!-- TODO: enforcer is full of upper bound dependency issues, including real ones --> | ||
| <enforcer.skip>true</enforcer.skip> |
There was a problem hiding this comment.
was hiding an awful lot of brokenness..
| <version>2.1.1</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
do not bundle things that should come from a library.
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.tmatesoft.svnkit</groupId> | ||
| <artifactId>svnkit</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.tmatesoft.svnkit</groupId> | ||
| <artifactId>svnkit</artifactId> | ||
| <version>1.10.4</version> |
There was a problem hiding this comment.
partially reverts a wrong attempt in #647
https://github.com/jfrog/jenkins-artifactory-plugin/pull/647/files#r1608554999
|
I have read the CLA Document and I hereby sign the CLA |
|
frogbot appears to be broken, and is not something I can fix in this PR as it is an action to which I have no access to update. it can not work out the packaging of type HPI, yet maven and JDK11 is completely happy with it. If frogbot and SCA are not happy with the versions used here, I have no idea how they can be happy with the previously historic versions used. |
plugin was bundling eddsa which is now a plugin and should be used instead.
whilst looking to fix this the dependencies where a bit of a mess and the plugin build (parent) obsolete and unsupported.
this is a partial fix for this (there is more outstanding) and it has had zero testing other than unit tests are fixed and there are less things bundled in the HPI that are obviously wrong.
the p4 code would not have even worked on a recent version of the perforce plugin as the APIs called where gone. I have adjusted the code so that it may work however other than it compiles and looks about right no testing has been performed.
fixes: #934
partially addresses: #933
passed.